Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: display full terms of service during onboarding #29392

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

feat: display full terms of service during onboarding #29392

wants to merge 19 commits into from
+1,481 −1,268

Conversation

jonybur
Copy link
Contributor

@jonybur jonybur commented Dec 20, 2024 •
edited
Loading

Description

During the onboarding process, the user is currently presented with a simple checkbox to agree to terms:

Screenshot 2024-08-12 at 14 15 34

Legal would prefer we show the full terms of service, requiring the user to scroll the entire terms and agree at the end.

Open in GitHub Codespaces

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3013

Manual testing steps

  1. Start onboarding
  2. See checkbox but without full terms.
  3. Verify full terms are displayed, requiring user to scroll and agree.

Screenshots/Recordings

Before

Screenshot 2024-08-12 at 14 15 34

After

demo.mp4

No response

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jonybur jonybur requested a review from a team as a code owner December 20, 2024 15:28
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jonybur jonybur changed the title feat: add feat: display full terms of service during onboarding Dec 20, 2024
@jonybur jonybur self-assigned this Jan 6, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [5d2206e]
Page Load Metrics (1771 ± 70 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint24220891706361173
domContentLoaded14822076174014670
load14872092177114570
domInteractive26224624723
backgroundConnect1085362311
firstReactRender177630189
getState55917168
initialActions01000
loadScripts10631651131013263
setupStore85525209
uiStartup17162364203116077

@jonybur
Copy link
Contributor Author

jonybur commented Jan 9, 2025 •
edited
Loading

For some reason, this is failing the playwright tests (they are not even being ran).
E2E tests are failing due to a flaky test. They are not failing on lastest commit 5d2206e, but they are on commit 24353cf; which only adds a couple of console logs for debugging purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jonybur jonybur

Labels
team-wallet-ux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonybur @metamaskbot